Skip to content

🔧 chore(jira): prevent EventLifecycle flow errors #95936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

🔧 chore(jira): prevent EventLifecycle flow errors #95936

merged 1 commit into from
Jul 21, 2025

Conversation

iamrajjoshi
Copy link
Member

resolves ECO-883

instead of recording halts multiple times, lets check if we need to record a halt and then do it.

@iamrajjoshi iamrajjoshi self-assigned this Jul 18, 2025
@iamrajjoshi iamrajjoshi requested review from a team as code owners July 18, 2025 21:20
@linear Linear
Copy link

linear bot commented Jul 18, 2025

ECO-883 EventLifecycle flow error: The lifecycle has already been exited

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 18, 2025
cursor[bot]
cursor bot reviewed Jul 18, 2025
View reviewed changes
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Logging Removal Masks Assignment Errors

The logger.info("inbound-assignee-not-found", extra=log_context) call was unintentionally removed during refactoring to consolidate halt recording logic. This eliminates per-instance logging when an assignee is not found, significantly reducing debugging and monitoring visibility for assignment issues.

src/sentry/integrations/utils/sync.py#L132-L141

sentry/src/sentry/integrations/utils/sync.py

Lines 132 to 141 in 33a7b34

groups_assigned.append(group)
else:
assignee_not_found = True
if assignee_not_found:
lifecycle.record_halt(
ProjectManagementHaltReason.SYNC_INBOUND_ASSIGNEE_NOT_FOUND, extra=log_context
)
return groups_assigned

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

Christinarlong
Christinarlong approved these changes Jul 21, 2025
View reviewed changes
src/sentry/integrations/utils/sync.py
Comment on lines +134 to +135
assignee_not_found = True

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add to the log context which users weren't found ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exercise left for the developer 😆

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jk its caused i already merged

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💀

@iamrajjoshi iamrajjoshi merged commit 3c588ad into master Jul 21, 2025
66 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/SENTRY-3JF1 branch July 21, 2025 23:15
andrewshie-sentry pushed a commit that referenced this pull request Aug 4, 2025
@iamrajjoshi @andrewshie-sentry
🔧 chore(jira): prevent EventLifecycle flow errors (#95936)
fb4cff1
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Christinarlong Christinarlong Christinarlong approved these changes

@cursor cursor[bot] cursor[bot] left review comments

Assignees

@iamrajjoshi iamrajjoshi

Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamrajjoshi @Christinarlong